-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab legacy fix #1414
Matlab legacy fix #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssun30 ... thanks for the bug fixes - the incorrect phase
for the Solution
was something that was introduced a while ago (#1109, I didn't catch this in my review) - in an earlier version, this used GRI-Mech, where the phase was correct.
I'm not sure that it's worth changing sample names or update formatting (beyond the newlines) - as this will become legacy code soon, I'd rather leave things as is, even if this doesn't exactly fit the mold.
As the remaining changes are modest, please squash your commits.
PS: Please feel free to add yourself to the AUTHORS
file in the root folder
Added Su Sun to AUTHORS.
a17ab0c
to
aff6c97
Compare
I've squashed all the changes and addressed all reviews. I think this is ready for merge. |
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
- Coverage 70.79% 70.78% -0.02%
==========================================
Files 373 373
Lines 53872 53872
Branches 17579 17579
==========================================
- Hits 38139 38131 -8
- Misses 13332 13339 +7
- Partials 2401 2402 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ssun30 - this looks good to me!
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
h2o2.yaml
, where the 'gas' phase is renamed to 'ohmech'. This affects examples that use this specific YAML file.test_examples.m
will run all examples without issues.Checklist
scons build
&scons test
) and unit tests address code coverage