-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polynomial Ea coverage dependency #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 375 375
Lines 58266 58292 +26
Branches 20807 20828 +21
=======================================
+ Hits 40935 40955 +20
- Misses 14348 14351 +3
- Partials 2983 2986 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, @jongyoonbae. I think it generally looks good, and I just had a couple of minor comments on the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @jongyoonbae. I found just one spot where I think an update is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jongyoonbae! This looks good to me.
Changes proposed in this pull request
InterfaceRate
on top of the current linear coverage dependency.E
incoverage-dependencies
is given as a scalar value.E
is given as a list of four values, the 4th-order polynomial dependency is applied.InterfaceRate.cpp
andInterfaceRate.h
as well as additional documentations inInterfaceRate.h
andreactions.rst
are appended.kineticsFromYaml.cpp
with additional dummy coverage dependency parameters insurface-phases.yaml
.If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage