Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Segfault Error for Experimental Matlab Toolbox #1498

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ssun30
Copy link
Contributor

@ssun30 ssun30 commented Jun 9, 2023

Changes proposed in this pull request

  • Added extra error handling for mole fraction and mass fraction setters in the new matlab toolbox.

If applicable, fill in the issue number this pull request is fixing

  • Setting X and Y with an empty array/string OR arrays of incorrect length (not matching the number of species) will cause a segfault error and instantly crashes Matlab.
  • This patch is necessary for the Matlab test suite (Matlab interface (new) test suite #1496) to run without crashing.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ssun30 ssun30 marked this pull request as ready for review June 9, 2023 01:39
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good to me!

@ischoegl ischoegl merged commit 44c8b6d into Cantera:main Jun 9, 2023
@ssun30 ssun30 mentioned this pull request Jun 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants