-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SolutionArray formatting consistent for different {fmt} versions #1547
Conversation
Make it explicit that these should be printed as integers. Behavior of {fmt} is different between 6.1.2, which always includes a decimal digit when the input type is double if no other formatting specifier is provided, and later versions which format integral doubles as doubles. Fixes Cantera#1526
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 70.49% 70.46% -0.03%
==========================================
Files 379 379
Lines 59091 59091
Branches 21228 21228
==========================================
- Hits 41658 41641 -17
- Misses 14353 14369 +16
- Partials 3080 3081 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on, @speth! ... I definitely appreciate that you were able to identify/resolve the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set up ubuntu-multiple-pythons
runners to use system_fmt=y
, so this is covered by CI?
This extends the tested versions to include fmt 6.1.2 on Ubuntu 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes proposed in this pull request
With {fmt} 6.1.2, this changes the output of:
from
to
If applicable, fill in the issue number this pull request is fixing
Closes #1526
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage