-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI linting for some code style issues #1566
Conversation
176d270
to
0debd0a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
- Coverage 70.52% 70.50% -0.02%
==========================================
Files 379 379
Lines 59110 59110
Branches 21232 21232
==========================================
- Hits 41688 41678 -10
- Misses 14347 14356 +9
- Partials 3075 3076 +1 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
#1561 is updated to preempt issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification - so, this looks great from my perspective!
Automate checks for some formatting issues that are easy to miss during pull request reviews.
Changes proposed in this pull request
git diff --check
: trailing whitespace, tabs in indentation, and CRLF line endings.If applicable, provide an example illustrating new features this pull request is introducing
CI will indicate failure and logs will include messages like the following for whitespace issues:
And like this for bare
/*!
comment blocks (without a preceding//!
block to provide the "brief" description):Checklist
scons build
&scons test
) and unit tests address code coverage