-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PyData Sphinx theme #1573
Conversation
This issue also encompasses the changes to the website side, too. Although pending the resolution of the content location, that may be less relevant. |
Yeah, I realize that there's more to it, but I kind of figure that falls under Cantera/cantera-website/issues/209, which requires picking some Sphinx theme. At least this way there's no point where we have two Sphinx sites with different themes. |
e47f2aa
to
49e9f21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from my side, but I don't have a complete overview about how this integrates with the website overhaul.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small suggestions for further cleanup here.
Co-authored-by: Sammo Gabay <[email protected]>
New requirement introduced in Cantera/cantera#1573. Removes dependency on KaTeX.
New requirement introduced in Cantera/cantera#1573. Removes dependency on KaTeX.
New requirement introduced in Cantera/cantera#1573. Removes dependency on KaTeX.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Resolves Cantera/cantera-website#210 (I think?)
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage