Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for 1D constant lambda #1598

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Aug 21, 2023

Also, add contributor

Changes proposed in this pull request

Add unit test to ensure lambda is constant (update to #1594)

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Also, add contributor
@ischoegl ischoegl marked this pull request as ready for review August 21, 2023 20:07
@ischoegl ischoegl requested a review from a team August 21, 2023 20:08
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1598 (f174772) into main (717af98) will increase coverage by 0.01%.
Report is 23 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   70.58%   70.60%   +0.01%     
==========================================
  Files         379      379              
  Lines       59164    59152      -12     
  Branches    21263    21252      -11     
==========================================
  Hits        41763    41763              
+ Misses      14327    14316      -11     
+ Partials     3074     3073       -1     

see 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth merged commit 9692e4e into Cantera:main Aug 21, 2023
42 checks passed
@ischoegl ischoegl deleted the update-1594 branch August 21, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants