Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for file output if radiative_heat_loss is enabled #993

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Mar 16, 2021

If applicable, fill in the issue number this pull request is fixing

Fixes #986

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@ischoegl ischoegl changed the title Fix bug for file output if radiative_heat_loss=True Fix bug for file output if radiative_heat_loss is enabled Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #993 (a130314) into main (e70371a) will decrease coverage by 0.95%.
The diff coverage is n/a.

❗ Current head a130314 differs from pull request most recent head deffc7f. Consider uploading reports for the commit deffc7f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   71.60%   70.64%   -0.96%     
==========================================
  Files         360      355       -5     
  Lines       45719    44311    -1408     
==========================================
- Hits        32736    31304    -1432     
- Misses      12983    13007      +24     
Impacted Files Coverage Δ
include/cantera/transport/DustyGasTransport.h 0.00% <0.00%> (-33.34%) ⬇️
...clude/cantera/transport/HighPressureGasTransport.h 0.00% <0.00%> (-33.34%) ⬇️
include/cantera/thermo/MixtureFugacityTP.h 0.00% <0.00%> (-20.00%) ⬇️
include/cantera/thermo/VPStandardStateTP.h 50.00% <0.00%> (-16.67%) ⬇️
include/cantera/thermo/GibbsExcessVPSSTP.h 14.28% <0.00%> (-10.72%) ⬇️
include/cantera/transport/WaterTransport.h 50.00% <0.00%> (-10.00%) ⬇️
include/cantera/thermo/ConstCpPoly.h 66.66% <0.00%> (-8.34%) ⬇️
include/cantera/transport/TransportData.h 66.66% <0.00%> (-8.34%) ⬇️
test_problems/shared/fileLog.h 42.85% <0.00%> (-7.15%) ⬇️
include/cantera/zeroD/IdealGasReactor.h 50.00% <0.00%> (-7.15%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70371a...deffc7f. Read the comment docs.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@speth speth merged commit 3f05b1e into Cantera:main Mar 19, 2021
@ischoegl ischoegl deleted the fix-986 branch October 17, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write_csv does not work for impingJet with radiation_enabled
2 participants