feat: simulations for canto modules #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: genesis import/export for govshuttle module * fix: empty port address bug * test: add assertion for empty port when govshuttle genesis import, export --------- Co-authored-by: dongsam <[email protected]>
This was referenced Aug 24, 2023
* fix: genesis import/export for CSR module * fix: gas, fee and send disabled issue when simulation * fix: add prefix exception due to null slice for TestAppImportExport --------- Co-authored-by: dongsam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simulation codes for following Canto modules:
csrepocherc20govshuttleinflationDuring the simulation process, the following issues were identified:
export/import genesis does not work ( CI/CD workflow fails because of this issue) for
govshuttlemodule due to missing Port address state in:export/import genesis for
csrmodule did not work due to the missing states in:Each of these issues were resolved in fix: genesis import/export for govshuttle module b-harvest/Canto#50 and fix: genesis import/export for CSR module b-harvest/Canto#51 accordingly.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...