ISSUE: #168 #187
ISSUE: #168 #187
Conversation
|
This fix multiple file selection on android. |
|
|
||
| guard let url = URL(string: urlString), let hostName = url.host else { | ||
| call.reject("Invalid URL") | ||
| return |
There was a problem hiding this comment.
why changes here? cookie is not related to file choose
| @@ -111,7 +111,8 @@ public boolean onShowFileChooser( | |||
| ) { | |||
| openFileChooser( | |||
| filePathCallback, | |||
| fileChooserParams.getAcceptTypes()[0] | |||
There was a problem hiding this comment.
Do this change still support one file only mode?
There was a problem hiding this comment.
ok just saw the comment upper
|
Look good can you just explain why the change in cookie? |
|
Tried this change out and it's still not working for my purposes in an auth flow. Would it be possible to add my custom solution in the associated issue as a separate method? Perhaps as a "clearAllCookies" function, since I think mine clears all the cookies for the in app browser? Would be a great help since this is the only Capacitor in-app browser plugin that I've found that has all the other functionality I need for my project. Clearing the cookies/cache is the only functionality I'm missing right now. |
I fixed also cookie and forgot to make a specific branch |
|
@Anthony-Matheou this PR is supposed to add multi file select, not cookie. |
|
Ok i added both fix myself in separate PR |
No description provided.