A0-2846: aleph-bft shouldn't quit after creator's graceful exit #314
Commits on Jul 31, 2023
-
FIX: aleph-bft was panicking in situations when creator decided to fi…
…nish early, which might happen if unit-backup was purged.
Commits on Aug 2, 2023
-
FIX: added
completebranch to select in terminal.rs. Without it cou……ld panic (which happened during tests).
-
Spawner::spawn_essential uses JoinHandle from tokio::spawn, instead o…
…f some custom oneshot channel, to allow await task completion.
-
-
-
working version of the consensus, where exit (even with panic) of cre…
…ator won't stop whole AlephBFT
-
-
-
Revert "Spawner::spawn_essential uses JoinHandle from tokio::spawn, i…
…nstead of some custom oneshot channel, to allow await task completion." This reverts commit ef90f0f.
Commits on Aug 3, 2023
-
Version of consensus.rs that is not watching for creator's panics. Th…
…is version also works, but kind of against the description of the SpawnHandle returned by substrate. Probably it is caused by setting a global panic handler on substrate's runner initialization.
-
Revert "Version of consensus.rs that is not watching for creator's pa…
…nics. This version also works, but kind of against the description of the SpawnHandle returned by substrate. Probably it is caused by setting a global panic handler on substrate's runner initialization." This reverts commit b8f4601.
-
Terminator: now if we call terminate_sync without being earlier notif…
…ied about exit from our parent, we continue to disable our offspring tasks, but without communicating it to our parent.
Commits on Aug 4, 2023
-
-
Changed log-line in consensus.rs - closed channel to creator is ok, u…
…ntil it has not panicked.
-
-
-
-
reverted part of the terminator.rs to use &str instead of String (it …
…was used for debugging)
-
FIX: fixed the way we are using Terminator in futures::select! - it w…
…as panicking without returning error, since oneshot::Receiver returned by Terminator was already implementing FusedFuture that behaved that way.