Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-2156-stop-the-world-calls #1079

Merged
merged 35 commits into from
Apr 11, 2023
Merged

A0-2156-stop-the-world-calls #1079

merged 35 commits into from
Apr 11, 2023

Conversation

fbielejec
Copy link
Collaborator

@fbielejec fbielejec commented Mar 23, 2023 •
edited
Loading

Description

Adding calls that halt trading in case of a major emergency
Simplified wAZERO prior to mainnet deployment

Type of change

  • New feature (non-breaking change which adds functionality)

@fbielejec fbielejec marked this pull request as draft March 23, 2023 12:46
@fbielejec fbielejec changed the title allow for dispatching A0-2156-stop-the-world-calls Mar 23, 2023
@fbielejec fbielejec marked this pull request as ready for review March 23, 2023 17:32
pmikolajczyk41
pmikolajczyk41 reviewed Mar 24, 2023
View reviewed changes
.github/workflows/contracts-deploy.yml Show resolved Hide resolved
.github/workflows/contracts-deploy.yml Show resolved Hide resolved
contracts/button/lib.rs Show resolved Hide resolved
contracts/marketplace/lib.rs Outdated Show resolved Hide resolved
contracts/marketplace/lib.rs Outdated Show resolved Hide resolved
contracts/marketplace/lib.rs Outdated Show resolved Hide resolved
contracts/marketplace/lib.rs Outdated Show resolved Hide resolved
contracts/marketplace/lib.rs Show resolved Hide resolved
contracts/simple_dex/lib.rs Outdated Show resolved Hide resolved
contracts/wrapped_azero/lib.rs Outdated Show resolved Hide resolved
pmikolajczyk41
pmikolajczyk41 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't resolve a few comments, but none of them is a blocker and I'm fine if you just resolve them

generally, great work 💪

.github/workflows/_check-excluded-packages.yml Show resolved Hide resolved
contracts/wrapped_azero/lib.rs Show resolved Hide resolved
deuszx
deuszx reviewed Mar 29, 2023
View reviewed changes
contracts/button/lib.rs Outdated Show resolved Hide resolved
deuszx
deuszx reviewed Mar 29, 2023
View reviewed changes
contracts/button/lib.rs Outdated Show resolved Hide resolved
mike1729
mike1729 requested changes Mar 29, 2023
View reviewed changes
contracts/button/lib.rs Show resolved Hide resolved
contracts/button/lib.rs Show resolved Hide resolved
contracts/simple_dex/lib.rs Show resolved Hide resolved
@fbielejec fbielejec merged commit a5199c8 into main Apr 11, 2023
@fbielejec fbielejec deleted the A0-2156-stop-the-world branch April 11, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszx deuszx deuszx left review comments

@pmikolajczyk41 pmikolajczyk41 pmikolajczyk41 approved these changes

@mike1729 mike1729 mike1729 approved these changes

@Marcin-Radecki Marcin-Radecki Awaiting requested review from Marcin-Radecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fbielejec @Marcin-Radecki @mike1729 @pmikolajczyk41 @deuszx @aleph-ci-user