Skip to content

Commit

Permalink
Merge pull request Point72#211 from Point72/tkp/checklint
Browse files Browse the repository at this point in the history
Check for python formatting changes in lint step
  • Loading branch information
timkpaine authored May 7, 2024
2 parents 6c57fb3 + 4717f54 commit 895563c
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,20 @@ jobs:
run: make test
if: ${{ contains( 'numpy', matrix.package )}}

###########################
#~~~~~~~~~~~~~~~~~~~~~~~~~#
#~~~~~~|#############|~~~~#
#~~~~~~|#|~~~~~~~/##/~~~~~#
#~~~~~~|#|~~~~~/##/~~~~~~~#
#~~~~~~~~~~~~/##/~~~~~~~~~#
#~~~~~~~~~~/##/~~~~~~~~~~~#
#~~~~~~~~/##/~~~~~~~~~~~~~#
#~~~~~~/##/~~~~~~~~~~~~~~~#
#~~~~~~~~~~~~~~~~~~~~~~~~~#
# Test Service Adapters #
#~~~~~~~~~~~~~~~~~~~~~~~~~#
# Coming soon!

#############################
#~~~~~~~~~~~~~~~~~~~~~~~~~~~#
#~~~~~~|#############|~~~~~~#
Expand Down
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ install: ## install library
lint-py:
python -m isort --check csp/ examples/ setup.py
python -m ruff check csp/ examples/ setup.py
python -m ruff format --check csp/ examples/ setup.py

lint-cpp:
# clang-format --dry-run -Werror -i -style=file `find ./cpp/ -name "*.*pp"`
Expand Down Expand Up @@ -194,9 +195,6 @@ dependencies-debian: ## install dependencies for linux
dependencies-fedora: ## install dependencies for linux
yum install -y automake bison ccache cmake curl flex perl-IPC-Cmd tar unzip zip

dependencies-alma: ## install dependencies for linux
dnf install -y automake bison ccache cmake curl flex perl-IPC-Cmd tar unzip zip

dependencies-vcpkg: ## install dependnecies via vcpkg
cd vcpkg && ./bootstrap-vcpkg.sh && ./vcpkg install

Expand Down
1 change: 1 addition & 0 deletions docs/wiki/dev-guides/Build-CSP-from-Source.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ make lint-py
# or
# python -m isort --check csp/ setup.py
# python -m ruff check csp/ setup.py
# python -m ruff format --check csp/ setup.py
```

**Python Autoformatting**
Expand Down

0 comments on commit 895563c

Please sign in to comment.