Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaks #35

Merged
merged 6 commits into from
May 23, 2019
Merged

Leaks #35

merged 6 commits into from
May 23, 2019

Conversation

Algunenano
Copy link

  • Silence GCC warnings around uv_after_work_cb functions.
  • Tests: Avoid Buffer() constructor.
  • Avoid dangling references when an error happenned before an async task

The current node 12 failure is due to a bug in 12.3.0 (nodejs/node#27803)

@Algunenano Algunenano self-assigned this May 22, 2019
@Algunenano
Silence GCC warnings around uv_after_work_cb functions
c3c0611
@Algunenano
Tests: Avoid Buffer()
ae599cf
@Algunenano
Avoid dangling references on errors
c65ce47 
- Always use auxiliar methods to add references.
- Fix several bugs where a reference was added and then an error
was thrown, leaving the referenced object alive forever.
@Algunenano
Update changelog
99274ee
@Algunenano
Do not throw on uv_after_work_cb functions
4317e9b 
It leaks both memory and references
@Algunenano
Update changelog
925fe7f
@Algunenano Algunenano merged commit f8f2cda into CartoDB:v3.6.2-carto May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Algunenano Algunenano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Algunenano