Fix off-by-one edge case bug when > 255 outputs in a transaction

CashScript · Oct 25, 2023 · 839d87a · 839d87a · vercel · Oct 25, 2023
1 parent 9234b8b
commit 839d87a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/cashscript/src/utils.ts b/packages/cashscript/src/utils.ts
@@ -12,6 +12,7 @@ import {
   LockingBytecodeType,
   encodeTransactionOutput,
   isHex,
+  bigIntToCompactSize,
 } from '@bitauth/libauth';
 import {
   encodeInt,
@@ -148,7 +149,7 @@ export function getTxSizeWithoutInputs(outputs: Output[]): number {
   let size = VERSION_SIZE + LOCKTIME_SIZE;
   size += outputs.reduce((acc, output) => acc + getOutputSize(output), 0);
   // Add tx-out count (accounting for a potential change output)
-  size += encodeInt(BigInt(outputs.length + 1)).byteLength;
+  size += bigIntToCompactSize(BigInt(outputs.length + 1)).byteLength;
 
   return size;
 }