Bugfix: withdrawn motions were amendable

CatoTH · Oct 4, 2024 · 7245866 · 7245866
1 parent ee40cdc
commit 7245866
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/History.md b/History.md
@@ -8,6 +8,7 @@
 - Custom input fields in motion forms can now have explanations. They can also be set to be "encouraged but not required" - that is, the user can skip them but will get a warning if they do so.
 - Bugfix: Tabular data was not encoded correctly in the PHP-based PDF export.
 - Bugfix: The PDF with all amendments embedded into the motion text could not be generated if a Weasyprint-based PDF layout was selected.
+- Bugfix: It was possible for users to submit amendments for withdrawn motions.
 
 ### Version 4.14.2 (2024-09-08)
 

diff --git a/models/settings/Permissions.php b/models/settings/Permissions.php
@@ -192,6 +192,8 @@ public function isCurrentlyAmendable(Motion $motion, bool $allowAdmins = true, b
                 }
             }
             $notAmendableStatuses = [
+                Motion::STATUS_WITHDRAWN,
+                Motion::STATUS_WITHDRAWN_INVISIBLE,
                 Motion::STATUS_DELETED,
                 Motion::STATUS_DRAFT,
                 Motion::STATUS_COLLECTING_SUPPORTERS,