forked from JuliaMolSim/DFTK.jl
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get this to precompile #4
Open
rkurchin
wants to merge
60
commits into
CedricTravelletti:AtomsCalculators
Choose a base branch
from
rkurchin:AtomsCalculators
base: AtomsCalculators
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
get this to precompile #4
rkurchin
wants to merge
60
commits into
CedricTravelletti:AtomsCalculators
from
rkurchin:AtomsCalculators
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of symmetries.
Signed-off-by: Rachel Kurchin <[email protected]>
mfherbst
force-pushed
the
AtomsCalculators
branch
from
July 28, 2024 19:20
1716373
to
eecb6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per @mfherbst's suggestion, was going to mess about with this branch in service of the ElectronicStructure ➡️ AtomsCalculators translator mentioned in JuliaMolSim/ElectronicStructure.jl#2, but noticed it wasn't precompiling. Took an embarrassingly long time to find, but turns out it was some pretty trivial missing
function
s 😆. Haven't really done anything else yet, but wanted to open this anyway so debugging work doesn't get duplicated.