Fix broken image scoring #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I also encountered the issue of "score image" only appear 2 positive 2 negative result using Github downloaded version. Is there anything I could do to circumvent the problem? Thanks. PS. Is this related to the software unable to connect to Github to update? |
|
Hi @AndyLAMHS, if you don't need 3D processing you could try using version 3.0.3 as a workaround for now. The update failure message is completely unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
Looks like something went wrong when implementing 3D mode, and the resulting coordinates list to draw onto images was being clipped to the first two elements.
GetObjectsCoordsshould only ever return 2D coordinates for objects as they're being mapped onto images. It appears that an attempt was made to have it return 3D, but this was only applied to the query portion rather than the downstream data processing. The attempt to round the third coordinate also doesn't appear to work as intended, though this isn't necessary anyway.To resolve this I've stripped that part of the function out. If 3D mode does need to show position in 3D then feel free to restore, though I can't see anything trying this in the code.