Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build modernization #54

Merged
merged 56 commits into from
Mar 15, 2024
Merged

Build modernization #54

merged 56 commits into from
Mar 15, 2024

Conversation

bethac07
Copy link
Member

See #53 for motivations

bethac07 and others added 30 commits December 21, 2023 13:30
I changed the embedding of the images and figures to be compatible with markdown text. Simplified small images in single file panels.
I deleted the last part because the cited notebook was not available anymore
I pulled the most recent version of Beginner Segmentation as a base for the simplified version
unify common button image names accors tutorials
make hierarchical titles for markdown
fix images in markdown
Unify button images accros tutorials
fix markdown images
fix title hierarchy
I used the modernized version of Beginner Segmentation as base
I used the modernized version of Beginner Segmentation as base
@bethac07
Copy link
Member Author

bethac07 commented Mar 15, 2024

@emiglietta and @PaulaLlanos, where do we stand with this?

My open q's/things I'd like to see before we pull (sooooo close, nice work!)

  • Has the code to update the POs been run( see eventually block here, and have updated POs been pushed here?
  • Can we add the instructions about that step to the instructions md (and also give it a typo check, I found a few)?
  • Do we want to keep both BS and BS_S? Or should your new one replace the old BS? If we're going to keep both, maybe this is me but "Beginner_Simplified" starts getting towards the point where i wonder if we're getting accidentally insulting - maybe something like Intro to Segmentation? I don't have super strong feelings here I just wanted to raise it.

I think that's it but I reserve the right to realize I've forgotten something lol

PaulaLlanos and others added 9 commits March 15, 2024 10:55
- add SaveImages module
- remove Costes threshold measurement to speed up
- add comments to pipelines
- updated html, toc and pdf files
…fication

final merge of this branch so the whole Build Modernization can be merged indo Master to update the Beginner tutorial before workshop
@emiglietta emiglietta merged commit d35290a into master Mar 15, 2024
@emiglietta emiglietta deleted the build_modernization branch March 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants