Antenna Map Viewer: Overlay of small Map Legend

[SecUpwN]

Hey guys, sorry for piling up Issues again. I have received feedback from people that they do use the Antenna Map Viewer but do not know what each circle on the map stands for. Solution: In the top right corner of our Antenna Map Viewer users can already change the Map Type and download the OCID data. I propose adding a small legend to overlay the map to quickly show what each circle stands for. This feature has also been requested in #13 (comment) and will certainly enhance the users experience.

[E3V3A]

Great idea, and I don't think we even need a button for that. A very small legend should suffice, and if the legend is clicked, a larger more details description is shown.

EDIT
The legend should of course reflect the BTS pins as described in #250.
Perhaps @ziem knows how to add a legend to the map?

[ziem]

@E3V3A Legend can be easily displayed above map like TextView with contributors. I can do it, just tell me what do you want it to look like?

[SecUpwN]

I can do it, just tell me what do you want it to look like?

Any examples you can link us to?

[ziem]

I was thinking about something similar to: https://bellevuentss.files.wordpress.com/2012/04/tap-google-map-legend.jpg .

[SecUpwN]

@ziem, looks great! I'd prefer some sort of gray background though and this thing should be small. But since I know you're a real pro coding stuff for maps, feel invited to craft an initial pull request! ;-)

[E3V3A]

Perfect, if it will use same icons.

[SecUpwN]

Please send a text description of the markers on the map (for the window, where they will show the markers and their description)

@DimaKoz, I have just updated the OP since we came to the conclusion that we don't need a button - a small map legend that overlays the map in the top right corner, similar to what @ziem suggested should be perfect. Here is my proposal of the legend asked for via E-Mail (separate coloring issue in #250):

PIN	EVENT
	Currently connected to this BTS
	Nearby and previously seen BTS
	Known imported BTS from OCID
	New or previously unknown BTS

Feel invited to correct me on the above suggestions if you disagree or if they are false.

[E3V3A]

Following #250, I suggest:

PIN	EVENT
	Currently connected BTS
	Well known encrypted BTS
	New or recently added BTS
	Unknown or insecure BTS

Additional comments:

1. Of course the legend should be without the table "header" shown above, to conserve screen space.
2. The blue pin should be centered and of reduced size, relative the others.

[SecUpwN]

@E3V3A, thanks for updating the legend. I fully agree and would love to see it added like this.
Who of you is going to do it, @ziem or @DimaKoz? Please tell us here to avoid double work.

[ziem]

I can do it, but after the weekend.

[SecUpwN]

I can do it, but after the weekend.

@ziem, yes, please give it a shot. Thank you for committing yourself to this.

[ziem]

Sorry for delay. Legend is almost ready:

Font size: 10sp.
Background color: #50ffffff.

What do you think about it? Do you have any suggestions how can I improve it?

[E3V3A]

Thanks @ziem! That above look very good. I still need to test. Is the legend transparent?

[ziem]

Yes, legend is transparent:

[SecUpwN]

What do you think about it? Do you have any suggestions how can I improve it?

Looks awesome and doesn't take away too much space. Do you think we'd need to add any sort of expanded descriptions when touching the legend, @E3V3A? In my eyes this thing seems about perfect.

[E3V3A]

The only thing I could think of, is an expanded explanation of the icons, in a pop-up window, when the legend is clicked. (We already have this elsewhere AFAIK.)

[SecUpwN]

(We already have this elsewhere AFAIK.)

Do you mean your descriptions from #250?

[E3V3A]

No I mean the ones in https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/wiki/Status-Icons and explanation that should be linked from the About drawer item.

[SecUpwN]

@E3V3A, I'm afraid I don't get what you want to accomplish. The explanations for the Status Icons have been implemented already, you can view them by clicking the Icons in the About menu. Please clarify.

[E3V3A]

I mean hitting the legend will take you there, unless there's a UX problem with doing that. (E.g. for small screens with large legend?)

[ziem]

Done - created pull request with map legend.

[SecUpwN]

Done - created pull request with map legend.

@ziem, awesome work! Just waiting for another Issue to be solved, will merge this soon.

I mean hitting the legend will take you there, unless there's a UX problem with doing that.

@E3V3A, the Status Icons page has nothing to do with the map legend and I would like to avoid adding too many links. If a user wants to now about the Status Icons, he can view the detailed descriptions through the About page. Furthermore, do we really need to explain anything more for the map legend? Should be pretty self-explanatory now. Let's give it a shot and see if we really need to add anything else.

[ziem]

@SecUpwN - thanks ;). If you would like me to help you with other things, let me know.

[SecUpwN]

If you would like me to help you with other things, let me know.

Thanks for the kind offer, @ziem! It would be awesome if you could send me a private email and let me know if you want to be listed on our team page. Generally speaking, I'd be extremely thankful if you could tackle any other open Issues (especially bugs) so that our app gets more stable with cleaner code.