-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Viewer BTS pin colors #250
Comments
Thanks for filing this, @E3V3A. I just contacted the author of |
Updated OP to reflect new pin coloring scheme. DEV's: Please discuss in locked HC room. |
I'm trying to put some new map pin icons. However, I just noticed and understood that since we're using an overlay (AFAIK), the icons doesn't scale down with the map when you zoom out. Thus they remain relatively huge, when zooming out. This make them look ugly and get bloated out with each other. We need to use non-overlay icons if possible. I suppose that means drawing (mostly circles) directly on the map. I have no idea if this will effect the performance. |
@evilsocket, I know you're already working on a different Issue, but could you have a quick look at this one, please? It sounds somewhat easy to fix, but it obviously isn't. Thank you for digging into it a little. |
will do asap |
@E3V3A, have you just fixed this by yourself with 463fec0? Also, did you notice that you did not respect the sizes for the map pins in their respective folders (for example: old pin is 32px and new 44px while both are in |
@SecUpwN Feel free to fix, but it looks a lot better on my phone, and I have no idea what it is using in terms of the x^ndpi blah blah. I tried with different sizes, and they where just too big and ugly...so until someone can come along and do this properly...it's hopefully better than nothing. I posted for some help at the Open Street Map Forums here. And some hints here. In addition, I'd like to see a rudimentary ruler on the map. Perhaps @ziem can help us, if we ask him very nicely? |
Alternatively we could consider to use marker clustering of the BTSs unless we can keep the markers very small. I actually prefer not to have this, for simplicity... |
I actually don't get if this is really done properly, but thanks for adding this quick fix though. @evilsocket could you please have a look at 463fec0 and see if we can let the new BTS pins like that? Ok can they be made generic? Having different sizes in the different |
Since about a 2-3 weeks back, the BTS points closest to "me" are not shown. I'm not sure what it causing this, but it could be a an OCID problem. Perhaps they've scrapped BTS that has been previously uploaded in my area. Only a proper working map function can fix and check this. |
Thanks to Toby's mention here: The dev site states:
So this will help make the correct sized pins. @tobykurien "DBe_import" is the new (future) name for the currently named "opencellid" table. (See comparison in #215.) The selection criteria in OP require that we add two new columns to this table: rej_cause and isGPSexact. I don't know exactly what data from OCID is actually downloaded versus what's used to populate that table. But the isGPSexact (BOOLEAN) column corresponds to the OCID "changeable". The rej-cause column is set to 0 by default, but should be obtained from #253. |
DEV NOTE: The default droplet pins have their pointed tips (near the bottom of the icon image) on the exact location on the map. So if we are using filled colored circles, their centers will be off, unless we make this adjustment to use the center of the icon image. This is specified for ItemizedOverlay and in MapView in the OSM source code. But only public enum HotspotPlace {
NONE, CENTER, BOTTOM_CENTER, TOP_CENTER, RIGHT_CENTER, LEFT_CENTER, UPPER_RIGHT_CORNER, LOWER_RIGHT_CORNER, UPPER_LEFT_CORNER, LOWER_LEFT_CORNER
} |
Since we don't have those columns in the database, this issue can't be implemented. In addition, you mention |
@tobykurien Yes, I know, it is very frustrating... 😱 But they should be added. 😰 I left |
Hello everyone! |
Wow, nice video! :) |
Thanks. Done. |
I'd like to see the single BTS (green) dots smaller with ~30% diameter of the orange clustered/numbered ones. While the orange ones with a size not much bigger than the font used to number it. |
NO this is not gonna get fixed until all statements have been resolved in OP. And since we don't have A5 info, nor new DB changes, I suppose this will take a while. |
@He3556, I don't see why this Issue has been closed either. This needs to be re-checked. |
The BTS pin colors as shown in the Map Viewer where previously loosely defined as:
However, this is neither logical nor according to our detection status. So we have to re-think what make more sense. In addition there may be other ways to display additional BTS information, for example, by using different size, shape or "letters" inside the pins. Perhaps the colors should be:
Samples: >3
andSamples: <4
orSamples: [0,-1]
orOne good source of inspiration can be found by the visually pleasing Antenna App:
Where he presents the various BTS as clearly labelled dots. (See image above.)
References: #13, #168, #206, #228
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: