Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy APK's to Github releases #682

Merged
merged 10 commits into from
Feb 13, 2016
Merged

Deploy APK's to Github releases #682

merged 10 commits into from
Feb 13, 2016

Conversation

larsgrefer
Copy link
Collaborator

Do not merge yet

@SecUpwN
Copy link
Member

SecUpwN commented Dec 12, 2015

@larsgrefer, I will add our real secure API key once I received it. Do not merge until that is done.

@larsgrefer
Copy link
Collaborator Author

real secure API key

What do you mean?

@SecUpwN
Copy link
Member

SecUpwN commented Dec 12, 2015

What do you mean?

The current API key inside of travis.yml is not the one that generates our real app signature, right?

skip_cleanup: true
provider: releases
api_key:
secure: hWL8k4eTm6RBA6JtY+zL/bFFm+f2eM466kKlHBrywukSXAThgX8VzHVu9I8u9bL1yP2j8R9XHmG+C49Fy8NZ85Hmj5ECFg3dGRhfxAzr3o3deP3Kaeo+LozGhOy/z2PvOPyHS7XqOK8kk8gmoMJ9jvhz+wFAbW9GxhKLYBMn81E=
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SecUpwN this api key is an (rsa encrypted) oauth-token for github which grants the deploy mechanism write access in my name to this repo. The write access is needed in order to attatch the files to the github-release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. But does that mean only you will be able to deploy releases?
Please send the keys to @He3556 as well to avoid problems when it may get lost.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everyone with write access is able to deploy releases, but the plan is, that only travis will do it.
With this api-token I've given travis access to this repo in order to deploy releases.

If @He3556 wants a token too, he can generate himself one here: https://github.com/settings/tokens/new (for travis the public_repo scope is needed)

@larsgrefer
Copy link
Collaborator Author

@SecUpwN The keystore passwords needed to create signed release apk wont be added to the .travis.yml file.

@SecUpwN
Copy link
Member

SecUpwN commented Dec 15, 2015

@larsgrefer, please mention me here once this PR is ready to be merged. Thank you.

@SecUpwN
Copy link
Member

SecUpwN commented Jan 6, 2016

@larsgrefer, I am now back on my personal high security data center below earth and have access to our keystore. ;-) Please provide me with some simple steps on what else is needed for automatic GitHub releases in my name. Do I need to change the api_key in .travis.yml into my own one for this repo?

@larsgrefer
Copy link
Collaborator Author

@SecUpwN There is no need to change the api_key

@SecUpwN
Copy link
Member

SecUpwN commented Jan 6, 2016

There is no need to change the api_key

Ok, thanks for letting me know. I just thought that because you added yours. Where to put the encrypted keystore? I remember you having told me that we need an encrypted version for signing the APK.

@larsgrefer
Copy link
Collaborator Author

@SecUpwN I've send you a mail

@SecUpwN SecUpwN changed the title deploy APK's to Github releases Deploy APK's to Github releases Jan 12, 2016
@SecUpwN
Copy link
Member

SecUpwN commented Jan 20, 2016

I've send you a mail

Short update: I'm still on it and am talking to Travis support to resolve my travis-encrypt setup Issues.

@larsgrefer
Copy link
Collaborator Author

@SecUpwN What kind of issues do you have?

@SecUpwN
Copy link
Member

SecUpwN commented Jan 26, 2016

What kind of issues do you have?

Installing travis-encrypt works, but when wanting to execute it, my system cannot find it. Stay tuned.

SecUpwN added a commit that referenced this pull request Feb 13, 2016
@SecUpwN SecUpwN merged commit f7361e4 into development Feb 13, 2016
@SecUpwN SecUpwN deleted the feature/travisDeploy branch February 13, 2016 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants