Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the main activity to use the material TabLayout #742

Closed
wants to merge 6 commits into from

Conversation

larsgrefer
Copy link
Collaborator

Don't merge

@larsgrefer larsgrefer self-assigned this Jan 7, 2016
@SecUpwN SecUpwN changed the title Restructure the main activity an use the material TabLayout Restructure the main activity to use the material TabLayout Jan 7, 2016
@SecUpwN
Copy link
Member

SecUpwN commented Jan 7, 2016

Thanks! What improves this, @larsgrefer? Please add a screenshot and a short sentence to the OP.

@larsgrefer
Copy link
Collaborator Author

I will split some of the things I've done here to different PR to better show what happens

@SecUpwN
Copy link
Member

SecUpwN commented Jan 8, 2016

I will split some of the things I've done here to different PR to better show what happens

@agilob, please be so kind and have a look at these things before we merge them. Thanks!

@larsgrefer
Copy link
Collaborator Author

@SecUpwN In fact the first of those PRs is already merged: #743

@SecUpwN
Copy link
Member

SecUpwN commented Jan 8, 2016

And I am thankful for your extremely hard work, @larsgrefer. Are you currently working on UI/UX? I am still worried that #258 has so many proposals on what to do or not to do. I just want our app to look and feel unique while at the same time being as easy to use as possible and be expandable for features.

@SecUpwN
Copy link
Member

SecUpwN commented Jan 13, 2016

@He3556, would you please have a look at this pull request and tell us if you approve it? Thanks!

@larsgrefer
Copy link
Collaborator Author

This PR is not finished yet

@SecUpwN
Copy link
Member

SecUpwN commented Jan 25, 2016

This PR is not finished yet

What is missing here? Seems as if thisPR now has a merge conflict as well.

@larsgrefer
Copy link
Collaborator Author

@SecUpwN The actionBar/Toolbar is broken in some activities

@SecUpwN
Copy link
Member

SecUpwN commented Mar 31, 2016

@CellularPrivacy/design would you please see if you can finish this pull request?

@larsgrefer larsgrefer closed this Sep 8, 2017
@larsgrefer larsgrefer deleted the feature/material/tabLayout branch September 8, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants