Add bootloader logos for m1n1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed https://issues.redhat.com/browse/RHEL-60809 for the centos-logos package in CentOS Stream 10. |
Add logos required by m1n1, a bootloader for Apple Silicon systems.
|
Images look good to me. @carlwgeorge do you have any consideration for packaging? |
|
I don't see anything in the current C10 spec file that will install these files, so after we merge this and tag a new version the spec file will need to be adjusted not just for the new version but also to install those files. I don't know off hand where in the system they should be installed, so ideally @davide125 can send an MR for those changes too. |
|
@carlwgeorge put up https://gitlab.com/redhat/centos-stream/rpms/centos-logos/-/merge_requests/8 to update the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logos required by m1n1, a bootloader for Apple Silicon systems. This
is the CentOS equivalent of https://pagure.io/fedora-logos/pull-request/21 and will allow building
m1n1 and asahi-installer in EPEL 10 (https://bugzilla.redhat.com/show_bug.cgi?id=2315498
https://bugzilla.redhat.com/show_bug.cgi?id=2315499), which are needed by the CentOS Hyperscale SIG to work on Apple Silicon enablement for CentOS Stream 10.