[dash] fix DASH ACL Rule protocol use-after-free (sonic-net#2958)

[dash] Updated the code to avoid using the vector (protocols) that goes out of scope before its data is used
CentecNetworks · Nov 22, 2023 · 2ca3deb · 2ca3deb
1 parent b8841ec
commit 2ca3deb
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/orchagent/dash/dashaclgroupmgr.cpp b/orchagent/dash/dashaclgroupmgr.cpp
@@ -378,18 +378,16 @@ void DashAclGroupMgr::createRule(DashAclGroup& group, DashAclRule& rule)
     attrs.emplace_back();
     attrs.back().id = SAI_DASH_ACL_RULE_ATTR_PROTOCOL;
 
-    if (rule.m_protocols.size())
-    {
-        attrs.back().value.u8list.count = static_cast<uint32_t>(rule.m_protocols.size());
-        attrs.back().value.u8list.list = rule.m_protocols.data();
-    }
-    else
-    {
-        auto protocols = all_protocols;
-        attrs.back().value.u8list.count = static_cast<uint32_t>(protocols.size());
-        attrs.back().value.u8list.list = protocols.data();
+    vector<uint8_t> protocols;
+    if (rule.m_protocols.size()) {
+        protocols = rule.m_protocols;
+    } else {
+        protocols = all_protocols;
     }
 
+    attrs.back().value.u8list.count = static_cast<uint32_t>(protocols.size());
+    attrs.back().value.u8list.list = protocols.data();
+
     if (!rule.m_src_prefixes.empty())
     {
         src_prefixes.insert(src_prefixes.end(),