Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic object assertions behave in a different way than other jsonnet implementations #125

Closed
wants to merge 1 commit into from
Closed

Cyclic object assertions behave in a different way than other jsonnet implementations #125

wants to merge 1 commit into from

Commits on Aug 2, 2023

  1. Allow recursion until stack overflow is hit 

    I have jsonnet code ressembling the `assert_recursion_allowed.jsonnet` file
This file evaluates fine in C jsonnet and go jsonnet but fails here because of `infinite recursion detected`

The fix I propose here is to now fail when recursion is detected but rather keep going until stack overflow is reached (as is done in other jsonnet interpreters)
I also modified the test for issue CertainLach#23. This issue is still fixed IMO because it doesn't panic. Instead, it prints out the full stack, which is what other jsonnet interpreters do, and it is a meaningful error message as well

Note: I am a complete Rust noob. My fix may be terrible. Let me know if it is!
    @julienduchesne
    julienduchesne committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8e76caf View commit details
    Browse the repository at this point in the history