Skip to content

Commit

Permalink
Tweak comments
Browse files Browse the repository at this point in the history
  • Loading branch information
j9liu committed Aug 30, 2022
1 parent e9e374d commit a18057c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Source/Scene/GltfLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ function loadInstancedAttribute(
modelSemantic === InstanceAttributeSemantic.TRANSLATION;

// Load the attributes as typed arrays only if:
// - the loader specifies (loadAttributesAsTypedArray)
// - loadAttributesAsTypedArray is true
// - the instances have rotations. This only applies to the transform attributes,
// since The instance matrices are computed on the CPU. This avoids the
// expensive quaternion -> rotation matrix conversion in the shader.
Expand Down
4 changes: 2 additions & 2 deletions Source/Scene/Model/I3dmLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ function I3dmLoader(options) {
this._postProcess = function (loader, frameState) {};

// Instanced attributes are initially parsed as typed arrays, but if they
// do not to be further processed (e.g. turned into transform matrices), it is
// more efficient to turn them into buffers. The I3dmLoader will own the
// do not need to be further processed (e.g. turned into transform matrices),
// it is more efficient to turn them into buffers. The I3dmLoader will own the
// resources and store them here.
this._buffers = [];
this._components = undefined;
Expand Down

0 comments on commit a18057c

Please sign in to comment.