Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing guide for Model #10738

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update testing guide for Model #10738

merged 1 commit into from
Aug 30, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Aug 30, 2022

this PR goes through the TestingGuide and updates details that were assuming the old Model implementation, and updates links to glTF models that have been reorganized.

@j9liu could you review when you get a chance?

@ptrgags ptrgags requested a review from j9liu August 30, 2022 18:57
@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@j9liu
Copy link
Contributor

j9liu commented Aug 30, 2022

@ptrgags looks good, I'll just wait for Travis to pass and merge. Thanks!

@j9liu j9liu merged commit 878374c into main Aug 30, 2022
@j9liu j9liu deleted the update-testing-guide branch August 30, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants