Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve from a separate build folder during development #10843

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Oct 6, 2022

Fixes #10836

Rather than having the npm start task build and serve content from Build/CesiumUnminified, this builds and copies content to Build/CesiumDev. This ensures we can still have a fresh build when running the task, while not overriding or removing any content from a previous build (such as make-zip).

In order to keep the existing Build/CesiumUnminified paths working without re-writing, server.jsnow redirects requests for Build/CesiumUnminified to the fresh Build/CesiumDev build.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor Author

ggetz commented Oct 10, 2022

@sanjeetsuhag Could you please review?

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz! Looks good. Can confirm that this fixes the issue with the release workflow.

@sanjeetsuhag sanjeetsuhag merged commit fdefbda into main Oct 10, 2022
@sanjeetsuhag sanjeetsuhag deleted the non-destructive-server branch October 10, 2022 12:37
ggetz pushed a commit that referenced this pull request Oct 10, 2022
Serve from a separate build folder during development
@sanjeetsuhag sanjeetsuhag mentioned this pull request Oct 21, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm start overrides CesiumUnminified
3 participants