Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up launch.json #10890

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Cleans up launch.json #10890

merged 1 commit into from
Nov 3, 2022

Conversation

sanjeetsuhag
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag commented Nov 3, 2022

This PR cleans up the launch.json that was polluted in #10824. The file is reverted back to what it was before the merge. The one change is changing the Chrome task from "pwa-chrome" to "chrome" as recommended by VS Code.

@cesium-concierge
Copy link

Thanks for the pull request @sanjeetsuhag!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor

ggetz commented Nov 3, 2022

Thanks @sanjeetsuhag!

@ggetz ggetz merged commit 627d61f into main Nov 3, 2022
@ggetz ggetz deleted the cleanup-launch-json branch November 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants