Fix 2D in IE/Edge #3898
Merged
Fix 2D in IE/Edge #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unds of the framebuffer. WIP.
|
👍 I can confirm IE and Edge now work as expected. |
|
Is it possible to add a test for this? Does anyone else want to review it? If not I'll merge once master is merged. |
|
I looked at adding a test to check the viewports like we discussed offline, but all of that is done by functions internal to the scene. There's no way to access them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3893.
2D is rendered with multiple viewports and part of those viewports were off screen. IE/Edge was clamping the viewports so that they fit the size of the drawing buffer. I'm not sure if that's a bug in IE/Edge or not, but we shouldn't be drawing off screen anyway.
@mramato Can you test with Edge?