OrthographicFrustum deprecated properties are removed. #5170
Conversation
|
Thanks @ateshuseyin! We don't want to merge this until the 1.33 release, so we'll wait until after the 1.32 release goes out on Monday. @bagnell does this look good to you? |
|
Can you also remove all references to the |
CHANGES.md
Outdated
| @@ -32,6 +32,7 @@ Change Log | |||
| * Fixed issues with imagerySplitPosition and the international date line in 2D mode. [#5151](https://github.com/AnalyticalGraphicsInc/cesium/pull/5151) | |||
| * Fixed an issue with `TileBoundingBox` that caused the terrain to disappear in certain places [4032](https://github.com/AnalyticalGraphicsInc/cesium/issues/4032) | |||
| * `QuadtreePrimitive` now uses `frameState.afterRender` to fire `tileLoadProgressEvent` [#3450](https://github.com/AnalyticalGraphicsInc/cesium/issues/3450) | |||
| * Removed left, right, bottom and top properties from `OrthographicFrustum`. | |||
There was a problem hiding this comment.
Move this up out of 1.32 changes.
|
Thanks for updating CHANGES.md, @ateshuseyin. Please comment on a PR after updating so the reviewers get notified. @emackey please merge when ready. |
|
@emackey is this good to go? If so, I can just reserve the conflict in CHANGES and merge. Thanks. |
|
No, sorry, there are test failures here, on the removed properties. |
| @@ -86,15 +78,6 @@ define([ | |||
| frustum._near = frustum.near; | |||
| frustum._far = frustum.far; | |||
|
|
|||
| if (!frustum._useDeprecated) { | |||
| var ratio = 1.0 / frustum.aspectRatio; | |||
There was a problem hiding this comment.
You need to keep these statements because frustum._useDeprecated would always be false.
…ve-orthographicfrustum-properties # Conflicts: # CHANGES.md
|
@emackey there are test failures and I cannot find the right solution. Could you help me? |
|
@ateshuseyin Oops, my previous comment was incorrect (so I deleted it). Check out the code that @bagnell pointed out. You removed a whole |
…ve-orthographicfrustum-properties # Conflicts: # CHANGES.md
|
Thanks @ateshuseyin. @bagnell tests pass now. Please merge when ready. |
|
Thanks again @ateshuseyin! |
fixes #5109