Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cameraEquals function to use epsilon15 #6171

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Adjust cameraEquals function to use epsilon15 #6171

merged 1 commit into from
Jan 30, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jan 30, 2018

Changed this value initially in #6115, adjusted it to use epsilon15.

@ggetz ggetz requested a review from mramato January 30, 2018 20:00
@cesium-concierge
Copy link

Signed CLA is on file.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Jan 30, 2018

Thanks @ggetz!

For those wondering about this change, because some of the camera values are computed, we can't guarantee they will always be exactly the same. We ran into a few views where this check failed even though the camera hadn't moved. This fixes that (and at 15 decimal places, won't miss any small changes).

@mramato mramato merged commit 6d7b078 into master Jan 30, 2018
@mramato mramato deleted the camera-check branch January 30, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants