Fix require for Node.js (Fixes #8559)

[jimmyangel]

No description provided.

[cesium-concierge]

Thank you so much for the pull request @jimmyangel! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

• ❌ Missing CONTRIBUTORS.md entry.
  • Please add yourself to the contributors file!
• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[mramato]

Now that we use ES6, you can just remove the nodeRequire variable and comment above it and just replace it with require directly in this function.

This will most likely have to all change again for Node 13, but there are bigger issues that need to be addressed there too.

[jimmyangel]

Ok, I will try that later today or sometime tomorrow. Thank you, Ricardo

…

On Wed, Jan 29, 2020 at 7:32 AM Matthew Amato ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Source/Core/Resource.js <#8560 (comment)> : > @@ -1902,7 +1902,7 @@ import TrustedServers from './TrustedServers.js'; // Specifically use the Node version of require to avoid conflicts with the global // require defined in the built version of Cesium. - var nodeRequire = global.require; // eslint-disable-line + var nodeRequire = global.require ? global.require : require; // eslint-disable-line Now that we use ES6, you can just remove the nodeRequire variable and comment above it and just replace it with require directly in this function. This will most likely have to all change again for Node 13, but there are bigger issues that need to be addressed there too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8560>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUGUQMEXLGMSGS6SZRRSVTRAGOQJANCNFSM4KJ3YJEA> .

[jimmyangel]

Hi @mramato, I made the change but there is a conflict in the contributors file :)

Thanks,

Ricardo

[mramato]

@jimmyangel I could have sworn I merged this already, but thanks again for the PR. It will be part of the CesiumJS release on Monday.