Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): set GODEBUG env in interop tests to avoid potential panics #4682

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Aug 26, 2024

Summary of changes

To address #4636 (comment)

Hi! I'm the author of rust2go. Thank you for choosing rustgo! In out production environment we have validated its relibility.

One thing to note is that, remember to add GODEBUG=invalidptr=0,cgocheck=0 env when run it, otherwise there maybe panic invalid pointer found on stack in go side when it tries to grow the goroutine stack(related code). This env can also be added with golang code on init: os.Setenv("GODEBUG", ...).

For testing, it doesn't matter whether there is this environment variable or not. But if you use it to serve requests, remember to add it.

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review August 26, 2024 09:17
@hanabi1224 hanabi1224 requested a review from a team as a code owner August 26, 2024 09:17
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team August 26, 2024 09:17
@hanabi1224 hanabi1224 added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 245a7d8 Aug 27, 2024
30 checks passed
@hanabi1224 hanabi1224 deleted the hm/set-godebug-env branch August 27, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants