Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ext_crypto_start_batch_verify and ext_crypto_finish_batch_verify to use go-schnorrkel BatchVerify #1405

Closed
noot opened this issue Feb 22, 2021 · 3 comments
Assignees

Comments

@noot
Copy link
Contributor

noot commented Feb 22, 2021

Task summary

@noot noot added wasm labels Feb 22, 2021
@noot noot changed the title update ext_crypto_start_batch_verify_version_1 and ext_crypto_finish_batch_verify_version_1 to use go-schnorrkel BatchVerify update ext_crypto_start_batch_verify and ext_crypto_finish_batch_verify to use go-schnorrkel BatchVerify Feb 22, 2021
@noot
Copy link
Contributor Author

noot commented Mar 8, 2021

can use this library for ed25519 batch verification: https://github.com/hdevalence/ed25519consensus/blob/main/batch.go

@danforbes
Copy link
Contributor

@noot I have removed this from the cross-client devnet Epic for now #1356 - does that seem correct? I think you mentioned that these methods may be deprecated, although they still seem to appear in the spec (ref https://w3f.github.io/polkadot-spec/develop/sect-crypto-api.html#sect-ext-crypto-start-batch-verify). I think this may still be worth doing but I don't see how it directly relates to #1356

@P1sar P1sar removed crypto labels Jan 15, 2024
@timwu20
Copy link
Contributor

timwu20 commented Jun 7, 2024

This isn't required anymore. They've deprecated these host api functions.

@timwu20 timwu20 closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants