Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib/runtime): update SignatureVerifier to use batch verifiers #1504

Closed
wants to merge 4 commits into from
Closed

chore(lib/runtime): update SignatureVerifier to use batch verifiers #1504

wants to merge 4 commits into from

Conversation

noot
Copy link
Contributor

@noot noot commented Apr 5, 2021

Changes

  • update SignatureVerifier to use batch verifiers for sr25519, ed25519 signatures
  • TODO: this causes block executions to fail, since batch verification was previously disabled

Tests

go test ./lib/runtime/... -short

Issues

@noot noot self-assigned this Apr 5, 2021
@noot
Copy link
Contributor Author

noot commented Jul 5, 2021

signature batching is currently disabled on mainnet, thus this is on pause. see paritytech/substrate#6616 for details

@noot
Copy link
Contributor Author

noot commented Jul 22, 2021

closing due to above comment

@noot noot closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior will be requested when the pull request is marked ready for review EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj will be requested when the pull request is marked ready for review jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 will be requested when the pull request is marked ready for review timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya will be requested when the pull request is marked ready for review kishansagathiya is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar will be requested when the pull request is marked ready for review P1sar is a code owner

Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update ext_crypto_start_batch_verify and ext_crypto_finish_batch_verify to use go-schnorrkel BatchVerify
2 participants
@noot @dutterbutter