feat: fallback to floodsub #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 83.22% 84.86% +1.64%
==========================================
Files 8 8
Lines 453 489 +36
==========================================
+ Hits 377 415 +38
+ Misses 76 74 -2
Continue to review full report at Codecov.
|
src/pubsub.js
Outdated
| * @returns {void} | ||
| */ | ||
| _dialPeer (peerInfo, callback) { | ||
| const onDial = (idB58Str, pubsubStopped, conn) => { |
There was a problem hiding this comment.
I'm not sure I understand the purpose of this function wrapper for _onDial
There was a problem hiding this comment.
I moved the logic to the _onDial function.
|
@wemeetagain @Mikerah @GregTheGreek can you have a look and merge this PR if you approve it? |
Hey sorry, I'm on it, I know @wemeetagain Is a bit under the weather |
Co-Authored-By: Jacob Heun <[email protected]>
Co-Authored-By: Jacob Heun <[email protected]>
vasco-santos
force-pushed
the
feat/fallback-to-floodsub
branch
from
f000cbb
to
fc9f13a
Compare
src/pubsub.js
Outdated
| @@ -186,6 +269,10 @@ class BasicPubSub extends Pubsub { | |||
| if (err) { | |||
| return callback(err) | |||
| } | |||
| // if fallback to floodsub enabled, we need to listen to its protocol | |||
| if (this._options.fallbackToFloodsub) { | |||
| this.libp2p.handle('/floodsub/1.0.0', this._onConnection) | |||
There was a problem hiding this comment.
consider pulling out the string into a constant.
There was a problem hiding this comment.
wait sorry! I will change it, I already have the constant 😅
|
Should be ready now @wemeetagain |
|
Thanks ❤️ |
Added a fallback to dial with other peers running floodsub, behind an option.
For this context, the
_dialPeerfunction was override fromlibp2p-pubsubto extend the dial behavior with the selection of the appropriate protocol to dial .