chore!: update protons and connection encryption interface #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Aug 10, 2022
|
this is a breaking change, changing the PR title |
wemeetagain
changed the title
wemeetagain
previously approved these changes
Aug 10, 2022
What is breaking change here? 😅 |
This was referenced Aug 11, 2022
achingbrain
requested changes
Aug 11, 2022
There was a problem hiding this comment.
This needs one final regeneration of the protobuf files with protons at 5.1.0 but then it should be good to go and will unblock libp2p/js-libp2p#1335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: secureInbound and secureOutbound now accept Duplex instead of any