feat: use libp2p component logger #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general pattern of stream muxers is to yield protocol stream data framed by some additional metadata - stream id, flags, etc. The frame data can be prepended/appended to the protocol stream data by using a `Uint8ArrayList` instead of a `Uint8Array`, this removes the need to copy the protocol data into a new `Uint8Array` for every frame. The new `@libp2p/interface` version allows muxers to emit `Uint8ArrayList`s as well as `Uint8Array`s so we can send protocol stream data to a transport in a no-copy operation.
|
#65 should be merged into master first, then this PR retargeted to master. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/support-yielding-uint8arraylists #66 +/- ##
=========================================================================
- Coverage 95.61% 95.52% -0.09%
=========================================================================
Files 14 14
Lines 2210 2211 +1
Branches 329 329
=========================================================================
- Hits 2113 2112 -1
- Misses 97 99 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Refactors code to use the component logger from libp2p to allow more flexible logging patterns. Refs: https://github.com/libp2p/js-libp2p/issue/2105 Refs: libp2p/js-libp2p#2198 Refs: https://github.com/libp2p/js-libp2p/issue/378
achingbrain
force-pushed
the
feat/use-libp2p-component-logger
branch
from
44ec1ad
to
00e3cb6
Compare
achingbrain
force-pushed
the
feat/support-yielding-uint8arraylists
branch
from
8495ae3
to
9a48fd3
Compare
Base automatically changed from
feat/support-yielding-uint8arraylists
to
master
November 29, 2023 14:47
|
Fixed in #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors code to use the component logger from libp2p to allow more flexible logging patterns.
Refs: https://github.com/libp2p/js-libp2p/issue/2105
Refs: libp2p/js-libp2p#2198
Refs: https://github.com/libp2p/js-libp2p/issue/378