Enable rule noUselessConstructor

ChainSafe · Sep 25, 2024 · 5615a91 · 5615a91
1 parent 4704ad3
commit 5615a91
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 41 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -32,7 +32,6 @@
         "noForEach": "off",
         "noStaticOnlyClass": "off",
         "noThisInStatic": "off",
-        "noUselessConstructor": "off",
         "noUselessEmptyExport": "off",
         "noUselessTypeConstraint": "off",
         "useArrowFunction": "off",

diff --git a/packages/beacon-node/src/util/queue/errors.ts b/packages/beacon-node/src/util/queue/errors.ts
@@ -7,11 +7,7 @@ export enum QueueErrorCode {
 
 export type QueueErrorCodeType = {code: QueueErrorCode.QUEUE_ABORTED} | {code: QueueErrorCode.QUEUE_MAX_LENGTH};
 
-export class QueueError extends LodestarError<QueueErrorCodeType> {
-  constructor(type: QueueErrorCodeType) {
-    super(type);
-  }
-}
+export class QueueError extends LodestarError<QueueErrorCodeType> {}
 
 export function isQueueErrorAborted(e: unknown): e is QueueError {
   return e instanceof QueueError && e.type.code === QueueErrorCode.QUEUE_ABORTED;

diff --git a/packages/fork-choice/src/forkChoice/errors.ts b/packages/fork-choice/src/forkChoice/errors.ts
@@ -95,8 +95,4 @@ export type ForkChoiceErrorType =
   | {code: ForkChoiceErrorCode.UNABLE_TO_SET_JUSTIFIED_CHECKPOINT; error: Error}
   | {code: ForkChoiceErrorCode.AFTER_BLOCK_FAILED; error: Error};
 
-export class ForkChoiceError extends LodestarError<ForkChoiceErrorType> {
-  constructor(type: ForkChoiceErrorType) {
-    super(type);
-  }
-}
+export class ForkChoiceError extends LodestarError<ForkChoiceErrorType> {}
diff --git a/packages/fork-choice/src/protoArray/errors.ts b/packages/fork-choice/src/protoArray/errors.ts
@@ -56,8 +56,4 @@ export type ProtoArrayErrorType =
   | {code: ProtoArrayErrorCode.INVALID_JUSTIFIED_EXECUTION_STATUS; root: RootHex}
   | ({code: ProtoArrayErrorCode.INVALID_LVH_EXECUTION_RESPONSE} & LVHExecError);
 
-export class ProtoArrayError extends LodestarError<ProtoArrayErrorType> {
-  constructor(type: ProtoArrayErrorType) {
-    super(type);
-  }
-}
+export class ProtoArrayError extends LodestarError<ProtoArrayErrorType> {}
diff --git a/packages/reqresp/src/encodingStrategies/sszSnappy/errors.ts b/packages/reqresp/src/encodingStrategies/sszSnappy/errors.ts
@@ -28,8 +28,4 @@ type SszSnappyErrorType =
   | {code: SszSnappyErrorCode.TOO_MANY_BYTES; sszDataLength: number}
   | {code: SszSnappyErrorCode.SOURCE_ABORTED};
 
-export class SszSnappyError extends LodestarError<SszSnappyErrorType> {
-  constructor(type: SszSnappyErrorType) {
-    super(type);
-  }
-}
+export class SszSnappyError extends LodestarError<SszSnappyErrorType> {}
diff --git a/packages/validator/src/slashingProtection/attestation/errors.ts b/packages/validator/src/slashingProtection/attestation/errors.ts
@@ -63,8 +63,4 @@ type InvalidAttestationErrorType =
       minTargetEpoch: Epoch;
     };
 
-export class InvalidAttestationError extends LodestarError<InvalidAttestationErrorType> {
-  constructor(type: InvalidAttestationErrorType) {
-    super(type);
-  }
-}
+export class InvalidAttestationError extends LodestarError<InvalidAttestationErrorType> {}
diff --git a/packages/validator/src/slashingProtection/block/errors.ts b/packages/validator/src/slashingProtection/block/errors.ts
@@ -25,8 +25,4 @@ type InvalidBlockErrorType =
       minSlot: Slot;
     };
 
-export class InvalidBlockError extends LodestarError<InvalidBlockErrorType> {
-  constructor(type: InvalidBlockErrorType) {
-    super(type);
-  }
-}
+export class InvalidBlockError extends LodestarError<InvalidBlockErrorType> {}
diff --git a/packages/validator/src/slashingProtection/interchange/errors.ts b/packages/validator/src/slashingProtection/interchange/errors.ts
@@ -12,8 +12,4 @@ type InterchangeErrorErrorType =
   | {code: InterchangeErrorErrorCode.UNSUPPORTED_VERSION; version: string}
   | {code: InterchangeErrorErrorCode.GENESIS_VALIDATOR_MISMATCH; root: Root; expectedRoot: Root};
 
-export class InterchangeError extends LodestarError<InterchangeErrorErrorType> {
-  constructor(type: InterchangeErrorErrorType) {
-    super(type);
-  }
-}
+export class InterchangeError extends LodestarError<InterchangeErrorErrorType> {}
diff --git a/packages/validator/src/slashingProtection/minMaxSurround/errors.ts b/packages/validator/src/slashingProtection/minMaxSurround/errors.ts
@@ -24,8 +24,4 @@ type SurroundAttestationErrorType =
       attestation2Target: number;
     };
 
-export class SurroundAttestationError extends LodestarError<SurroundAttestationErrorType> {
-  constructor(type: SurroundAttestationErrorType) {
-    super(type);
-  }
-}
+export class SurroundAttestationError extends LodestarError<SurroundAttestationErrorType> {}