Merge ea7ef2f into f48bef0

ChainSafe · Aug 30, 2022 · 73efabf · 73efabf
2 parents f48bef0 + ea7ef2f
commit 73efabf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/beacon-node/src/network/reqresp/reqResp.ts b/packages/beacon-node/src/network/reqresp/reqResp.ts
@@ -1,3 +1,4 @@
+import {setMaxListeners} from "node:events";
 import {Connection} from "libp2p";
 import {HandlerProps} from "libp2p/src/registrar";
 import LibP2p from "libp2p";
@@ -71,6 +72,9 @@ export class ReqResp implements IReqResp {
 
   async start(): Promise<void> {
     this.controller = new AbortController();
+    // We set infinity to prevent MaxListenersExceededWarning which get logged when listeners > 10
+    // Since it is perfectly fine to have listeners > 10
+    setMaxListeners(Infinity, this.controller.signal);
     for (const [method, version, encoding] of protocolsSupported) {
       await this.libp2p.handle(
         formatProtocolId(method, version, encoding),

diff --git a/packages/beacon-node/src/node/nodejs.ts b/packages/beacon-node/src/node/nodejs.ts
@@ -1,3 +1,4 @@
+import {setMaxListeners} from "node:events";
 import LibP2p from "libp2p";
 import {Registry} from "prom-client";
 
@@ -118,6 +119,9 @@ export class BeaconNode {
     metricsRegistries = [],
   }: IBeaconNodeInitModules): Promise<T> {
     const controller = new AbortController();
+    // We set infinity to prevent MaxListenersExceededWarning which get logged when listeners > 10
+    // Since it is perfectly fine to have listeners > 10
+    setMaxListeners(Infinity, controller.signal);
     const signal = controller.signal;
 
     // start db if not already started

diff --git a/packages/validator/src/validator.ts b/packages/validator/src/validator.ts
@@ -121,6 +121,10 @@ export class Validator {
     }
 
     const emitter = new ValidatorEventEmitter();
+    // Validator event emitter can have more than 10 listeners in a normal course of operation
+    // We set infinity to prevent MaxListenersExceededWarning which get logged when listeners > 10
+    emitter.setMaxListeners(Infinity);
+
     const chainHeaderTracker = new ChainHeaderTracker(logger, api, emitter);
 
     this.blockProposingService = new BlockProposingService(config, loggerVc, api, clock, validatorStore, metrics, {