-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement regen metrics #2153
Comments
From #2285 (comment) |
@dapplion please assign |
If you need help to design the metrics on this component reach out to me or Cayman. Be aware that the regen logic is quite complex with many entrypoints. Doing the metrics right will be much harder than the fork choice and require a good understatement of it mechanics. |
@dapplion thanks, will try to figure it out while I implement other simpler metrics. Will circle back on this once I get a priliminary understanding. 👍 |
ok, i think i have a preliminary understanding of the regen module basis which I propose following metrics structure: regenStateCacheLookupTotal: gauge<entrypointFn,callingModule> regenCPStateCacheLookupTotal: gauge<entrypointFn,callingModule> where entrypointFn label in ['getPreState','getCheckpointState','getState','getBlockSlotState'] This will give a good slicing, dicing and rollups to figure out and debut what is happening. @dapplion @wemeetagain let me know your thoughts on the same. |
I thinkthe lookup / hits is a good start. Here's how I see the regen module, there's a few different loads in the regen module that may happen, from best to worst:
And then there's the error case, when the state can't be regenerated for whatever reason. I think some other things I'd like to know, where metrics could help:
|
The text was updated successfully, but these errors were encountered: