Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics to add tracker #2468

Open
3 of 7 tasks
dapplion opened this issue May 2, 2021 · 5 comments · Fixed by #2811
Open
3 of 7 tasks

Metrics to add tracker #2468

dapplion opened this issue May 2, 2021 · 5 comments · Fixed by #2811
Labels
Epic Issues used as milestones and tracking multiple issues. scope-metrics All issues with regards to the exposed metrics.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 2, 2021

Ready to execute

Metric ideas

Misc

Once properly defined, convert to issue or pull request and move above to "Ready to execute"

  • Improve state.clone() metrics, what we really care about is before doing state-transitions if the state has cache or not.
  • Add more sync metrics to measure efficiency: # blocks downloaded to process # of blocks. To count duplicated downloads indirectly.
  • Discv5 ping times
  • Gossipsub received blocks
  • Blocks in last epoch, to compute percent of orphaned
  • More HTTP metrics?

From Lighthouse

Reviewed this file and select interesting metrics to add
https://github.com/sigp/lighthouse/blob/stable/beacon_node/beacon_chain/src/metrics.rs

Block Delay Metrics

  • beacon_block_imported_slot_start_delay_time: Duration between the start of the blocks slot and the current time when it was imported.
  • beacon_block_head_slot_start_delay_time: Duration between the start of the blocks slot and the current time when it was as head.
  • beacon_block_head_slot_start_delay_exceeded_total: Triggered when the duration between the start of the blocks slot and the current time will result in failed attestations. feat: add setHeadAfterFirstInterval metric #5559

Persisting BeaconChain components to disk

  • beacon_persist_head: Time taken to persist the canonical head
  • beacon_persist_op_pool: Time taken to persist the operations pool - Does Lighthouse keep all ops in memory?
  • beacon_persist_eth1_cache: Time taken to persist the eth1 caches

Chain Head

  • beacon_update_head_seconds: Time taken to update the canonical head - Review what does it refer too
@dapplion dapplion added the scope-metrics All issues with regards to the exposed metrics. label May 2, 2021
@dapplion dapplion mentioned this issue May 24, 2021
10 tasks
@g11tech
Copy link
Contributor

g11tech commented Jun 18, 2021

assign please

@g11tech
Copy link
Contributor

g11tech commented Jun 27, 2021

@dapplion these looks like good metrics to pick up next ?

@dapplion
Copy link
Contributor Author

dapplion commented Jun 27, 2021

@dapplion these looks like good metrics to pick up next ?

I think the next interesting group to add would be around block production. Note that lighthouse has very detailed timings on each step of the process. Our approach to block production is more simple so maybe a single histogram around the entire thing would suffice. We are already kind of tracking it via the API response times, but it would be nice to track it anyway.

  • beacon_block_production_requests_total: Count of all block production requests
  • beacon_block_production_successes_total: Count of blocks successfully produced
  • beacon_block_production_seconds: Full runtime of block production

At the same time it would be quite a priority to have metrics in our regen / state cache: #2153. Let's discuss details in that issue if you are interested.

@dapplion
Copy link
Contributor Author

dapplion commented Jul 6, 2021

Keeping open since there are some metrics we want to implement soonish too

@philknows
Copy link
Member

Adding some ideas to this from @wemeetagain discussion in Columbia that I found in my notes:

  • Block size metrics (due to 4844 blobs) to test performance
  • Number of operations per block
  • Metrics on exits, slashings, deposits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issues used as milestones and tracking multiple issues. scope-metrics All issues with regards to the exposed metrics.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants