Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove I prefix from types that are not really interfaces #3652

Closed
2 tasks
dapplion opened this issue Jan 21, 2022 · 3 comments
Closed
2 tasks

Remove I prefix from types that are not really interfaces #3652

dapplion opened this issue Jan 21, 2022 · 3 comments
Assignees
@dapplion
Labels
meta-technical-debt Issues introducing or resolving technical debts.

Comments

@dapplion
Copy link
Contributor

A linting rule has forced many types into having an I prefix when they don't represent a class interface. Overall this I pattern in a legacy approach ported from Java that doesn't really help too much in the current paradigm of lodestar

Todo:

  • Remove lint rule forcing I prefix
  • Search and replace type names prefixed by I that do NOT have a class representation. For example: remove from IBeaconConfig do NOT remove from IBeaconChain
@dapplion dapplion self-assigned this Jan 21, 2022
@philknows
Copy link
Member

@dapplion, although this is something we are working towards, can I remove this style requirement from contribution.md then?

@dapplion
Copy link
Contributor Author

@dapplion, although this is something we are working towards, can I remove this style requirement from contribution.md then?

Oh, yes please

@dapplion dapplion added the meta-technical-debt Issues introducing or resolving technical debts. label May 10, 2022
@dapplion dapplion mentioned this issue Feb 14, 2023
Merged
@nflaig
Copy link
Member

nflaig commented May 1, 2023

Resolved by #5145

@nflaig nflaig closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dapplion dapplion

Labels
meta-technical-debt Issues introducing or resolving technical debts.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dapplion @nflaig @philknows