Remove unnecessary I prefix interfaces #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
previously approved these changes
Feb 14, 2023
| dbWriteItems: ICounter<"bucket">; | ||
| } | ||
| export type LevelDbControllerMetrics = { | ||
| dbReadReq: Counter<"bucket">; |
There was a problem hiding this comment.
There is an inconsistency how metric interfaces outside of the beacon-node are defined. ICounter is updated to Counter whereas others such as IHistogram is not because it is implemented by a class in the beacon-node but not the actual package where it is used.
All the metric types defined in state-transition metrics could remove the I-prefix. But maybe for consistency should always use interface with I-prefix for metrics
|
need to rebase against unstable and re-run script before merging |
- some values were incorrectly updated InboundRateLimitQuota --> nboundRateLimitQuota - few I-prefixed types such as IChainConfig were missed - updated names of types in comments as this was not done by script
dapplion
force-pushed
the
dapplion/remove-i-prefix
branch
from
77e2204
to
17b6a44
Compare
|
I have manually double checked all files 🤣 all good but damn.. |
twoeths
previously approved these changes
Feb 20, 2023
g11tech
previously approved these changes
Feb 20, 2023
|
same, was kinda painful 😂 but load all file diffs was a life saver P.S: should not merge yet, there are few missing changes need to pull in from last commit of #5174
|
Closed
g11tech
approved these changes
Feb 20, 2023
twoeths
approved these changes
Feb 20, 2023
|
🎉 This PR is included in v1.6.0 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Almost all changes are performed automatically with script below. Non script changes:
Loggerimported from winstonThe script output is