Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state cloneCount metric #3680

Closed
dapplion opened this issue Jan 29, 2022 · 0 comments · Fixed by #4128
Closed

Add state cloneCount metric #3680

dapplion opened this issue Jan 29, 2022 · 0 comments · Fixed by #4128
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-metrics All issues with regards to the exposed metrics.

Comments

@dapplion
Copy link
Contributor

dapplion commented Jan 29, 2022

Is your feature request related to a problem? Please describe.

New SSZ version uses a strategy of state cache transfer which provides great performance improvements. However, after cloning a state, subsequent clones will get an empty cache that must be re-populated.

Then it's important to know how many times a single state is cloned now, to estimate the effectiveness of this cache transfer strategy.

From #3760

Describe the solution you'd like

  • Add a metric to get the number of clone() calls at a single state object. Every time when calling clone() add 1 to a counter of clonedCount, and register a histogram metric of cloneCount at cloned(). If states are used exactly once then the average will be 0. If states are clone multiple times the average will be greater than zero
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-metrics All issues with regards to the exposed metrics. labels Jan 29, 2022
This was referenced May 10, 2022
@wemeetagain wemeetagain added this to the Sprint: July 15, 2022 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-metrics All issues with regards to the exposed metrics.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants