Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github workflows to avoid ::set-output #4967

Closed
wemeetagain opened this issue Jan 3, 2023 · 2 comments · Fixed by #5002 or #5078
Closed

Update github workflows to avoid ::set-output #4967

wemeetagain opened this issue Jan 3, 2023 · 2 comments · Fixed by #5002 or #5078
Assignees
@twoeths
Labels
prio-high Resolve issues as soon as possible. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Milestone
v1.4.0

Comments

@wemeetagain
Copy link
Member

We need to update our github workflows to not use ::set-output. We have by May 31 2023 to do so.

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@philknows
Copy link
Member

Will tag this one to a release milestone due to the timeline requirement.

@philknows philknows added this to the v1.4.0 milestone Jan 4, 2023
@philknows philknows added prio-high Resolve issues as soon as possible. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. labels Jan 4, 2023
@twoeths twoeths self-assigned this Jan 13, 2023
@twoeths twoeths mentioned this issue Jan 13, 2023
Merged
@twoeths
Copy link
Contributor

twoeths commented Jan 30, 2023

Still get 21 warnings in https://github.com/ChainSafe/lodestar/actions/runs/4040952032
Screen Shot 2023-01-30 at 13 39 13

Screen Shot 2023-01-30 at 13 39 39

@twoeths twoeths reopened this Jan 30, 2023
@twoeths twoeths mentioned this issue Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoeths twoeths

Labels
prio-high Resolve issues as soon as possible. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Avoid set-output in workflows ChainSafe/lodestar
Fix github action warnings ChainSafe/lodestar
3 participants
@wemeetagain @twoeths @philknows