Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github action warnings #5078

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix github action warnings #5078

merged 1 commit into from
Jan 30, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jan 30, 2023

Motivation

Description

  • set-output: same fix to Avoid set-output in workflows #5002 but for js file
  • Node.js 12 actions: migrate to latest version of actions
  • set-state: I don't see we use it in lodestar, not sure where it comes from

Closes #4967

@twoeths twoeths requested a review from a team as a code owner January 30, 2023 07:55
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8bfe45f Previous: 2a2a9ef Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.1787 ms/op 996.26 us/op 1.18
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 61.231 us/op 59.240 us/op 1.03
BLS verify - blst-native 2.1775 ms/op 2.1748 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 4.4993 ms/op 4.4879 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 9.7270 ms/op 9.6959 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 35.347 ms/op 35.253 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 46.623 us/op 46.700 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 182.88 us/op 182.41 us/op 1.00
getAttestationsForBlock 78.001 ms/op 76.565 ms/op 1.02
isKnown best case - 1 super set check 450.00 ns/op 474.00 ns/op 0.95
isKnown normal case - 2 super set checks 457.00 ns/op 465.00 ns/op 0.98
isKnown worse case - 16 super set checks 439.00 ns/op 467.00 ns/op 0.94
CheckpointStateCache - add get delete 8.2960 us/op 8.1710 us/op 1.02
validate gossip signedAggregateAndProof - struct 5.0212 ms/op 5.0188 ms/op 1.00
validate gossip attestation - struct 2.3715 ms/op 2.3613 ms/op 1.00
pickEth1Vote - no votes 2.4864 ms/op 2.5015 ms/op 0.99
pickEth1Vote - max votes 17.650 ms/op 16.180 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.295 ms/op 13.242 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.101 ms/op 21.076 ms/op 1.00
pickEth1Vote - Eth1Data fastSerialize value x2048 1.1351 ms/op 1.1259 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize tree x2048 10.929 ms/op 9.7575 ms/op 1.12
bytes32 toHexString 1.0500 us/op 872.00 ns/op 1.20
bytes32 Buffer.toString(hex) 653.00 ns/op 662.00 ns/op 0.99
bytes32 Buffer.toString(hex) from Uint8Array 988.00 ns/op 1.0110 us/op 0.98
bytes32 Buffer.toString(hex) + 0x 665.00 ns/op 698.00 ns/op 0.95
Object access 1 prop 0.35800 ns/op 0.31500 ns/op 1.14
Map access 1 prop 0.27000 ns/op 0.30500 ns/op 0.89
Object get x1000 10.648 ns/op 10.775 ns/op 0.99
Map get x1000 0.97200 ns/op 0.98500 ns/op 0.99
Object set x1000 68.046 ns/op 71.935 ns/op 0.95
Map set x1000 44.571 ns/op 42.484 ns/op 1.05
Return object 10000 times 0.43250 ns/op 0.43420 ns/op 1.00
Throw Error 10000 times 6.6067 us/op 6.6876 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 4.9060 us/op 4.9570 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 534.00 ns/op 545.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 200 bytes 717.00 ns/op 726.00 ns/op 0.99
fastMsgIdFn sha256 / 1000 bytes 15.672 us/op 15.720 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 697.00 ns/op 708.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 1000 bytes 829.00 ns/op 821.00 ns/op 1.01
fastMsgIdFn sha256 / 10000 bytes 137.10 us/op 137.21 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.5870 us/op 2.5880 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.7770 us/op 1.7920 us/op 0.99
enrSubnets - fastDeserialize 64 bits 2.3290 us/op 2.3730 us/op 0.98
enrSubnets - ssz BitVector 64 bits 927.00 ns/op 947.00 ns/op 0.98
enrSubnets - fastDeserialize 4 bits 330.00 ns/op 281.00 ns/op 1.17
enrSubnets - ssz BitVector 4 bits 919.00 ns/op 919.00 ns/op 1.00
prioritizePeers score -10:0 att 32-0.1 sync 2-0 151.63 us/op 147.96 us/op 1.02
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 176.21 us/op 173.19 us/op 1.02
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 251.05 us/op 255.56 us/op 0.98
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 439.56 us/op 440.30 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 498.81 us/op 497.39 us/op 1.00
array of 16000 items push then shift 51.796 us/op 51.638 us/op 1.00
LinkedList of 16000 items push then shift 12.378 ns/op 12.454 ns/op 0.99
array of 16000 items push then pop 201.37 ns/op 192.74 ns/op 1.04
LinkedList of 16000 items push then pop 12.244 ns/op 12.025 ns/op 1.02
array of 24000 items push then shift 77.421 us/op 77.372 us/op 1.00
LinkedList of 24000 items push then shift 12.866 ns/op 12.496 ns/op 1.03
array of 24000 items push then pop 196.76 ns/op 196.19 ns/op 1.00
LinkedList of 24000 items push then pop 12.245 ns/op 12.091 ns/op 1.01
intersect bitArray bitLen 8 21.638 ns/op 21.697 ns/op 1.00
intersect array and set length 8 142.69 ns/op 123.58 ns/op 1.15
intersect bitArray bitLen 128 71.054 ns/op 71.072 ns/op 1.00
intersect array and set length 128 1.6587 us/op 1.6541 us/op 1.00
Buffer.concat 32 items 5.2010 us/op 5.2280 us/op 0.99
Uint8Array.set 32 items 3.8230 us/op 3.6520 us/op 1.05
pass gossip attestations to forkchoice per slot 3.6965 ms/op 3.6605 ms/op 1.01
computeDeltas 4.3766 ms/op 4.3088 ms/op 1.02
computeProposerBoostScoreFromBalances 2.4961 ms/op 2.4974 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 3.7680 ms/op 3.4452 ms/op 1.09
altair processAttestation - 250000 vs - 7PWei worstcase 5.8780 ms/op 5.8739 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 177.59 us/op 176.89 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 360.01 us/op 353.31 us/op 1.02
altair processAttestation - setStatus - 1/2 committees join 540.24 us/op 513.99 us/op 1.05
altair processAttestation - setStatus - 2/3 committees join 672.96 us/op 674.80 us/op 1.00
altair processAttestation - setStatus - 4/5 committees join 946.11 us/op 942.74 us/op 1.00
altair processAttestation - setStatus - 100% committees join 1.1447 ms/op 1.1290 ms/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 22.726 ms/op 22.210 ms/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase hashState 36.788 ms/op 38.622 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 80.131 ms/op 78.943 ms/op 1.02
altair processBlock - 250000 vs - 7PWei worstcase hashState 118.02 ms/op 98.982 ms/op 1.19
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2314 ms/op 3.1593 ms/op 1.02
phase0 processBlock - 250000 vs - 7PWei worstcase 51.490 ms/op 50.816 ms/op 1.01
altair processEth1Data - 250000 vs - 7PWei normalcase 664.96 us/op 667.72 us/op 1.00
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.6840 us/op 7.8140 us/op 1.11
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 39.483 us/op 22.988 us/op 1.72
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 10.231 us/op 10.354 us/op 0.99
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 10.059 us/op 9.3330 us/op 1.08
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 89.297 us/op 90.184 us/op 0.99
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 960.96 us/op 883.52 us/op 1.09
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.1757 ms/op 1.1671 ms/op 1.01
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.2592 ms/op 1.1262 ms/op 1.12
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 4.1529 ms/op 4.1230 ms/op 1.01
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 2.5545 ms/op 2.5158 ms/op 1.02
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 6.8934 ms/op 7.0472 ms/op 0.98
Tree 40 250000 create 636.94 ms/op 599.62 ms/op 1.06
Tree 40 250000 get(125000) 262.65 ns/op 271.60 ns/op 0.97
Tree 40 250000 set(125000) 2.0040 us/op 2.0457 us/op 0.98
Tree 40 250000 toArray() 25.713 ms/op 26.462 ms/op 0.97
Tree 40 250000 iterate all - toArray() + loop 26.443 ms/op 26.804 ms/op 0.99
Tree 40 250000 iterate all - get(i) 103.02 ms/op 104.22 ms/op 0.99
MutableVector 250000 create 13.709 ms/op 14.146 ms/op 0.97
MutableVector 250000 get(125000) 10.713 ns/op 10.714 ns/op 1.00
MutableVector 250000 set(125000) 490.10 ns/op 526.11 ns/op 0.93
MutableVector 250000 toArray() 6.4101 ms/op 5.4526 ms/op 1.18
MutableVector 250000 iterate all - toArray() + loop 6.0283 ms/op 5.9615 ms/op 1.01
MutableVector 250000 iterate all - get(i) 2.7902 ms/op 3.1049 ms/op 0.90
Array 250000 create 5.2483 ms/op 5.5178 ms/op 0.95
Array 250000 clone - spread 2.0163 ms/op 2.4837 ms/op 0.81
Array 250000 get(125000) 0.98600 ns/op 1.2070 ns/op 0.82
Array 250000 set(125000) 0.97700 ns/op 1.1950 ns/op 0.82
Array 250000 iterate all - loop 150.90 us/op 150.92 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 32.926 us/op 151.22 us/op 0.22
effectiveBalanceIncrements clone MutableVector 300000 571.00 ns/op 503.00 ns/op 1.14
effectiveBalanceIncrements rw all Uint8Array 300000 244.94 us/op 243.97 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 142.41 ms/op 132.92 ms/op 1.07
phase0 afterProcessEpoch - 250000 vs - 7PWei 187.57 ms/op 186.38 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 55.834 ms/op 56.630 ms/op 0.99
altair processEpoch - mainnet_e81889 542.89 ms/op 551.54 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 149.85 ms/op 75.653 ms/op 1.98
mainnet_e81889 - altair processJustificationAndFinalization 20.719 us/op 20.694 us/op 1.00
mainnet_e81889 - altair processInactivityUpdates 9.0651 ms/op 8.9375 ms/op 1.01
mainnet_e81889 - altair processRewardsAndPenalties 116.01 ms/op 136.81 ms/op 0.85
mainnet_e81889 - altair processRegistryUpdates 4.4790 us/op 2.7090 us/op 1.65
mainnet_e81889 - altair processSlashings 917.00 ns/op 520.00 ns/op 1.76
mainnet_e81889 - altair processEth1DataReset 866.00 ns/op 604.00 ns/op 1.43
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.1406 ms/op 2.6891 ms/op 0.80
mainnet_e81889 - altair processSlashingsReset 6.1430 us/op 4.2600 us/op 1.44
mainnet_e81889 - altair processRandaoMixesReset 7.0830 us/op 4.6240 us/op 1.53
mainnet_e81889 - altair processHistoricalRootsUpdate 993.00 ns/op 586.00 ns/op 1.69
mainnet_e81889 - altair processParticipationFlagUpdates 3.7480 us/op 2.1750 us/op 1.72
mainnet_e81889 - altair processSyncCommitteeUpdates 687.00 ns/op 527.00 ns/op 1.30
mainnet_e81889 - altair afterProcessEpoch 196.62 ms/op 196.13 ms/op 1.00
phase0 processEpoch - mainnet_e58758 490.05 ms/op 482.99 ms/op 1.01
mainnet_e58758 - phase0 beforeProcessEpoch 202.52 ms/op 177.02 ms/op 1.14
mainnet_e58758 - phase0 processJustificationAndFinalization 23.233 us/op 18.167 us/op 1.28
mainnet_e58758 - phase0 processRewardsAndPenalties 66.344 ms/op 68.725 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 11.939 us/op 8.0760 us/op 1.48
mainnet_e58758 - phase0 processSlashings 706.00 ns/op 531.00 ns/op 1.33
mainnet_e58758 - phase0 processEth1DataReset 1.0420 us/op 507.00 ns/op 2.06
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6343 ms/op 2.0450 ms/op 0.80
mainnet_e58758 - phase0 processSlashingsReset 5.6750 us/op 3.3520 us/op 1.69
mainnet_e58758 - phase0 processRandaoMixesReset 7.8610 us/op 4.4210 us/op 1.78
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0840 us/op 630.00 ns/op 1.72
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.8110 us/op 3.7540 us/op 1.55
mainnet_e58758 - phase0 afterProcessEpoch 165.17 ms/op 163.97 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9973 ms/op 1.9694 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.2227 ms/op 2.5337 ms/op 0.88
altair processInactivityUpdates - 250000 normalcase 34.139 ms/op 27.853 ms/op 1.23
altair processInactivityUpdates - 250000 worstcase 42.196 ms/op 32.440 ms/op 1.30
phase0 processRegistryUpdates - 250000 normalcase 10.976 us/op 6.7680 us/op 1.62
phase0 processRegistryUpdates - 250000 badcase_full_deposits 436.19 us/op 380.01 us/op 1.15
phase0 processRegistryUpdates - 250000 worstcase 0.5 182.49 ms/op 184.04 ms/op 0.99
altair processRewardsAndPenalties - 250000 normalcase 111.42 ms/op 93.669 ms/op 1.19
altair processRewardsAndPenalties - 250000 worstcase 85.683 ms/op 97.069 ms/op 0.88
phase0 getAttestationDeltas - 250000 normalcase 13.496 ms/op 12.171 ms/op 1.11
phase0 getAttestationDeltas - 250000 worstcase 12.851 ms/op 12.450 ms/op 1.03
phase0 processSlashings - 250000 worstcase 5.3178 ms/op 5.0254 ms/op 1.06
altair processSyncCommitteeUpdates - 250000 290.51 ms/op 293.45 ms/op 0.99
BeaconState.hashTreeRoot - No change 481.00 ns/op 495.00 ns/op 0.97
BeaconState.hashTreeRoot - 1 full validator 71.386 us/op 66.087 us/op 1.08
BeaconState.hashTreeRoot - 32 full validator 701.81 us/op 748.67 us/op 0.94
BeaconState.hashTreeRoot - 512 full validator 7.1761 ms/op 7.2022 ms/op 1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 89.915 us/op 81.482 us/op 1.10
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2556 ms/op 1.2959 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.301 ms/op 17.166 ms/op 1.01
BeaconState.hashTreeRoot - 1 balances 63.415 us/op 69.138 us/op 0.92
BeaconState.hashTreeRoot - 32 balances 657.89 us/op 627.02 us/op 1.05
BeaconState.hashTreeRoot - 512 balances 6.2577 ms/op 6.3054 ms/op 0.99
BeaconState.hashTreeRoot - 250000 balances 107.88 ms/op 95.068 ms/op 1.13
aggregationBits - 2048 els - zipIndexesInBitList 23.763 us/op 23.549 us/op 1.01
regular array get 100000 times 60.562 us/op 60.601 us/op 1.00
wrappedArray get 100000 times 60.533 us/op 60.526 us/op 1.00
arrayWithProxy get 100000 times 25.326 ms/op 25.426 ms/op 1.00
ssz.Root.equals 1.0270 us/op 968.00 ns/op 1.06
byteArrayEquals 1.0260 us/op 942.00 ns/op 1.09
shuffle list - 16384 els 11.399 ms/op 11.501 ms/op 0.99
shuffle list - 250000 els 167.49 ms/op 167.54 ms/op 1.00
processSlot - 1 slots 13.438 us/op 13.278 us/op 1.01
processSlot - 32 slots 1.9249 ms/op 1.9610 ms/op 0.98
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 460.92 us/op 357.32 us/op 1.29
getCommitteeAssignments - req 1 vs - 250000 vc 5.4404 ms/op 5.4327 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 7.9900 ms/op 7.9612 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 8.5493 ms/op 8.5033 ms/op 1.01
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 7.6800 ns/op 7.6800 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1390 us/op 1.2243 us/op 0.93
computeProposers - vc 250000 17.287 ms/op 17.478 ms/op 0.99
computeEpochShuffling - vc 250000 171.64 ms/op 171.81 ms/op 1.00
getNextSyncCommittee - vc 250000 292.58 ms/op 291.00 ms/op 1.01

by benchmarkbot/action

@wemeetagain wemeetagain merged commit adb2309 into unstable Jan 30, 2023
@wemeetagain wemeetagain deleted the tuyen/fix_github_action_warnings branch January 30, 2023 22:47
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update github workflows to avoid ::set-output
2 participants
@twoeths @wemeetagain