Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import big slashing protection #5392

Closed
caevv opened this issue Apr 20, 2023 · 5 comments · Fixed by #5461
Closed

Cannot import big slashing protection #5392

caevv opened this issue Apr 20, 2023 · 5 comments · Fixed by #5461
Assignees
Labels
scope-ux Issues for CLI UX or general consumer UX.

Comments

@caevv
Copy link

caevv commented Apr 20, 2023

Internal server error. Error: Maximum call stack size exceeded

Running with --keymanager.bodyLimit 11125829120

28M file

@nflaig
Copy link
Member

nflaig commented Apr 21, 2023

Thanks for reporting @caevv, I will look into this

@nflaig nflaig self-assigned this Apr 21, 2023
@philknows philknows added the scope-ux Issues for CLI UX or general consumer UX. label Apr 23, 2023
@nflaig
Copy link
Member

nflaig commented Apr 29, 2023

@caevv I am not able to reproduce the issue, even with a bigger slashing protection file it seems to work fine for me. Would it be possible for you to provide some logs of your validator client? The error log should contain the stack trace which would be really helpful to further analyse this issue.

You can observe the logs by running ./ethd logs -f validator or you could just search for the specific log by running ./ethd logs validator | grep "Maximum call stack size exceeded" -A10 -B10.

@caevv
Copy link
Author

caevv commented May 3, 2023

Sorry for the delay, here it is:

eth-docker-validator-1  | May-03 19:45:18.833[]                 info: Verified connected beacon node and validator have the same genesisValidatorRoot
eth-docker-validator-1  | May-03 19:45:18.835[]                 info: doppelganger protection enabled detectionEpochs=1
eth-docker-validator-1  | May-03 19:45:18.872[]                 info: Started REST API server address=http://0.0.0.0:7500
eth-docker-validator-1  | May-03 19:45:18.872[]                 warn: REST API server is exposed, ensure untrusted traffic cannot reach this API
eth-docker-validator-1  | May-03 19:45:18.872[]                 info: REST api server keymanager bearer access token located at:
eth-docker-validator-1  |
eth-docker-validator-1  | /var/lib/lodestar/validators/validator-db/api-token.txt
eth-docker-validator-1  |
eth-docker-validator-1  | May-03 19:57:53.054[]                error: Req req-1 importKeystores error  Maximum call stack size exceeded
eth-docker-validator-1  | RangeError: Maximum call stack size exceeded
eth-docker-validator-1  |     at minEpoch (file:///usr/app/packages/validator/src/slashingProtection/utils.ts:31:35)
eth-docker-validator-1  |     at SlashingProtectionAttestationService.importAttestations (file:///usr/app/packages/validator/src/slashingProtection/attestation/index.ts:148:28)
eth-docker-validator-1  |     at processTicksAndRejections (node:internal/process/task_queues:95:5)
eth-docker-validator-1  |     at SlashingProtection.importInterchange (file:///usr/app/packages/validator/src/slashingProtection/index.ts:64:7)
eth-docker-validator-1  |     at KeymanagerApi.importKeystores (file:///usr/app/packages/cli/src/cmds/validator/keymanager/impl.ts:123:7)
eth-docker-validator-1  |     at Object.handler (file:///usr/app/packages/api/src/utils/server/genericJsonServer.ts:44:23)
❯ ls -la ~/eth-docker/.eth/validator_keys/
total 28544
drwxr-xr-x 2 a a       75 May  3 19:44 .
drwxr-xr-x 4 a a       58 Apr 19 21:17 ..
-rw-r--r-- 1 a a      786 May  3 19:44 keystore-0.json
-rwxr-xr-- 1 a a 29223063 May  3 19:44 slashing_protection.json
❯ cat .env
...
VC_EXTRAS='--keymanager.bodyLimit 11125829120'
...

@nflaig
Copy link
Member

nflaig commented May 4, 2023

Thanks @caevv for providing the logs, that helped a lot, a fix is on the way!

@nflaig
Copy link
Member

nflaig commented May 5, 2023

@caevv The issue should be fixed in chainsafe/lodestar:next release and will be included in v1.9.0 which will be released in ~2-3 weeks

Using eth-docker you can test if it works by updating LS_DOCKER_TAG in your .env file

LS_DOCKER_TAG=next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@caevv @nflaig @philknows and others